Skip to content

changelog.d/wire-service-label: document need for StatefulSet/Deployment recreation#2472

Merged
flokli merged 1 commit intodevelopfrom
release-notes-resource-recreation
Jun 10, 2022
Merged

changelog.d/wire-service-label: document need for StatefulSet/Deployment recreation#2472
flokli merged 1 commit intodevelopfrom
release-notes-resource-recreation

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Jun 10, 2022

The wireService label was also used in the spec.selector.matchLabels field
on existing Deployment / StatefulSet resources.
As these fields being immutable, changing them isn't possible without recreation.

Update the release notes to document this fact, and how to handle it.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

…ent recreation

The `wireService` label was also used in the `spec.selector.matchLabels` field
on existing `Deployment` / `StatefulSet` resources.
As these fields being immutable, changing them isn't possible without recreation.

Update the release notes to document this fact, and how to handle it.
@flokli flokli requested a review from julialongtin June 10, 2022 11:55
@flokli flokli temporarily deployed to cachix June 10, 2022 11:55 Inactive
@flokli flokli marked this pull request as ready for review June 10, 2022 11:55
@flokli flokli merged commit 7d7b727 into develop Jun 10, 2022
@flokli flokli deleted the release-notes-resource-recreation branch June 10, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants